search

robertmeta / nofrils

An extremely minimalist colorscheme, even opting out of the second L in frills
MIT License
324 stars 44 forks source link

Change ColorColumn to match CursorColumn #7

Closed joshgillies closed 8 years ago

robertmeta commented 8 years ago

Why would you want ColorColumn to look like CursorColumn?

joshgillies commented 8 years ago

Sorry, I should have left more of a description.

Personally I have: let &colorcolumn=join(range(81,999),","), and with the nofrils-dark default ColorColumn I find theres too much contrast. I'll attach a screenshot to illustrate the difference.

screen shot 2016-03-22 at 11 21 21 am

robertmeta commented 8 years ago

Thank you so much for the clarification! Unfortunately, I suspect this is a fairly rare configuration and fixing it for your case would make it worse for the more common case. I might add an optional behavior like strbackgrounds.

Wouldn't you want it to be different from cursorcolumn (else cursorcolumn would vanish on the right side)?

joshgillies commented 8 years ago

Oh I'm sure there's a better way of managing this, and my usage of ColorColumn is very likely an edge-case. But having an optional setting could be a good way around this.

Wouldn't you want it to be different from cursorcolumn (else cursorcolumn would vanish on the right side)?

Interestingly enough, even with the default settings CursorCulumn falls behind ColorColumn (see screenshot in my last post).

robertmeta commented 8 years ago

CursorLine is blown out by ColorColumn, ColorColumn is interestingly not. But, I think just having a less aggressive set of colors will handle this best for all cases.

robertmeta commented 8 years ago

I committed much milder color shifts for ColorColumn that work with CursorLine and CursorColumn -- hopefully that will work for you and others.

joshgillies commented 8 years ago

Latest commit is :ok_hand: thanks for pushing this out, and for your work on nofrils! Really loving this minimal colour scheme. :clap: