coveralls
commented
4 years ago Pull Request Test Coverage Report for Build 50
- 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage remained the same at 100.0%
| Totals | |
|---|---|
| Change from base Build 49: | 0.0% |
| Covered Lines: | 353 |
| Relevant Lines: | 353 |
I've been seeing errors when connecting to Salesforce for 'client identifier invalid'. The errors happen sporadically, so it's not something on our end, it's Salesforce. I found some posts that recommend using your domain instead of 'login.salesforce.com'. I updated the repo to allow that.
In addition, for some salesforce instances like Gov Cloud instances, you can't actually login with 'login.salesforce.com', you HAVE to use the custom domain. This allows support for that.
I allowed use of 'sandbox' OR 'domain', but not both. Using both raises a ValueError since it would be difficult to judge what the user intended. I added tests for these scenarios, and all the other tests pass.