search

roberto-butti / some-drops-of-javascript

This book collects some useful, unknown, underrated JavaScript functions discovered and learned while using JavaScript daily.
https://drops-of-javascript.hi-folks.dev/
Other
137 stars 40 forks source link

:pencil: adds 05_getting-all-the-object-properties-attributes #10

Closed SyedaMahamFahim closed 11 months ago

SyedaMahamFahim commented 11 months ago

Chapter 03 - 05_Getting all the Object properties/attributes: key()

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
some-drops-of-javascript ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 7:50pm
roberto-butti commented 11 months ago

Thank you @SyedaMahamFahim, for the PR. If you allow me, I would like to provide feedback on this. I think that you explained well the keys() function. But in general, I would like to provide more context in each explanation. For example, mention some use cases when the reader can use the function. For example, walking through all the properties with a loop. Or counting the properties. Or checking the existence of some properties (with additional usage of other functions),.

I would like to add some tips, like about the order of the attributes etc.

If you think that "is too much" to add, i will be happy to merge this PR, and i will add this additional information. Or if you prefer to add them, let me know, I am happy to support you. And thanks again for your contribution

SyedaMahamFahim commented 11 months ago

Hey @roberto-butti, I've taken a look at chapter 3 style, the typeof was explained in a short term. so I thought to follow the style, But don't worry, I'm not done yet! I'll review it again make sure everything is perfect and provide an even more detailed explanation.

roberto-butti commented 11 months ago

Thank you @SyedaMahamFahim I'm going to merge this PR ... thank you for your all effort and high quality PRs. Welcome to the "club"