Added documentation for array-splice() method along with its examples (Fixes #43)

roberto-butti / some-drops-of-javascript

This book collects some useful, unknown, underrated JavaScript functions discovered and learned while using JavaScript daily.

https://drops-of-javascript.hi-folks.dev/

Other

137 stars 40 forks source link

Added documentation for array-splice() method along with its examples (Fixes #43) #44

Closed wdym69 closed 6 days ago

wdym69 commented 1 week ago

Tasks done:

Added documentation for splice() method
Added examples for splice() method

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
some-drops-of-javascript	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 16, 2024 7:52am

roberto-butti commented 1 week ago

Amazing, thank you @wdym69 . I appreciate all your effort.

If I can provide some suggestions:

I see you pushed all the examples with formatting options from a new Prettier version. This is fine, but eventually, it is better to raise a specific PR.
I would like to have four sections (second-level title), with an Introduction where you can explain an overview of the splice command and then three main use cases, such as adding items, removing items, and replacing items.

What do you think? If you agree with the feedback and want, you can push an additional commit. Otherwise, I can start merging the PR, and eventually, I can review it and raise an additional PR.

Let me know.

wdym69 commented 6 days ago

Thankyou for the suggestions @roberto-butti . I agree with the feedback and will push another commit soon.

Edit: I will raise a new PR

wdym69 commented 6 days ago

i have a doubt:

what version of prettier are we using here? as we use npx prettier ./examples/ --write and don't specifically mention the prettier version it automatically uses the latest version. so should i raise two different PR's? one for Array.splice() documentation and other for examples as it uses latest prettier version (as suggested) Please help!

roberto-butti commented 6 days ago

hi @wdym69 , you can use the latest version of prettier.

the latest one introduces a lot of code style fixes. so is better in my opinion to raise 2 PRs , one with the code style fixes on the examples directory, and another one ( PR ) for splice documentation and example.