roberto-butti / some-drops-of-javascript

This book collects some useful, unknown, underrated JavaScript functions discovered and learned while using JavaScript daily.
https://drops-of-javascript.hi-folks.dev/
Other
151 stars 46 forks source link

Added documentation for Array.findIndex() method #56

Closed Prakhar29Sharma closed 1 month ago

Prakhar29Sharma commented 1 month ago

I've added documentation for Array.findIndex() method with proper chapter structure as mentioned in the CONTRIBUTORS.md. file created : 15_array-findindex.md

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
some-drops-of-javascript ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 6:32am
roberto-butti commented 1 month ago

Thank you for your PR. I think is a good chapter, well written and very clear. If you want, you can also add the example in the examples/ directory. Let me know if you want to add the example, otherwise, i can add it :)

Thank you

Prakhar29Sharma commented 1 month ago

Thanks for the feedback @roberto-butti. I'll do the changes and add the example

roberto-butti commented 1 month ago

Thank you, i will review it tomorrow early morning (Europe timezone).

roberto-butti commented 1 month ago

This is super @Prakhar29Sharma ! Thank you for your contribution, i also like the example when no elements match the criteria and also the additional notes are helpful.

roberto-butti commented 1 month ago

One thing is noticed @Prakhar29Sharma , is about the file name. You should name the file with the number 16 and not 15: 02-array/16_array-findindex.md Also the example should be 16 and not 15. Do you want to change? if you don't have time, or you don't want it , i can do it . Let me know :)

Prakhar29Sharma commented 1 month ago

Yes, I'll do it

Prakhar29Sharma commented 1 month ago

Hey @roberto-butti, I've changed the file name as requested. If there's anything else let me know.

roberto-butti commented 1 month ago

Hi @Prakhar29Sharma , thank you, I'm going to merge your helpful PR! Close #52