search

robertogallea / laravel-codicefiscale

Codice fiscale validation for php/laravel
MIT License
42 stars 16 forks source link

CheckForWrongCode #7

Closed makroxyz closed 4 years ago

makroxyz commented 4 years ago

Why CheckForWrongCode isn't in private checks attribute in CodiceFiscale.php?

robertogallea commented 4 years ago

I cannot remember any valid reasons for that. Perhaps I just forgot to include it.

makroxyz commented 4 years ago

I made a pull request with this and another fix, could you have a look please?

robertogallea commented 4 years ago

Sure, I asked you to fix CircleCI warning before merging, thanks!