search

robertoostenveld / arduino

Arduino electronics hacking
http://robertoostenveld.nl/category/arduino/
202 stars 96 forks source link

Added an option to use a common anode RGB LED. #1

Closed cmoore42 closed 7 years ago

cmoore42 commented 7 years ago

This change simply reverses the high/low sense of the LED outputs, for use with a common anode RGB LED instead of a common cathode.

Because this difference is determined by hardware design I figured it made more sense to make in an #ifdef rather than making it configurable at run time.

robertoostenveld commented 7 years ago

thanks, makes sense!

cmoore42 commented 7 years ago

I’ve got some other changes too – I can send them to you if want.

I found that, at least on my NodeMCU, the “break” wasn’t working. The code switches baud rate to 57600 and sends a 0, which seems like it should work, but I was still getting only about 40 us of low for the break. I added a C++ function to access the ESP8266 uart function and generate a break that way, and it works for me now.

Let me know if you’d like a pull request for that change.

Chris

From: Robert Oostenveld [mailto:notifications@github.com] Sent: Saturday, August 19, 2017 12:53 AM To: robertoostenveld/arduino arduino@noreply.github.com Cc: cmoore42 chrismoore@surewest.net; Author author@noreply.github.com Subject: Re: [robertoostenveld/arduino] Added an option to use a common anode RGB LED. (#1)

thanks, makes sense!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/robertoostenveld/arduino/pull/1#issuecomment-323507918 , or mute the thread https://github.com/notifications/unsubscribe-auth/AEIlDuc25kisn0-S0p5mysfJZlMeMy53ks5sZpR3gaJpZM4Ouf2m . https://github.com/notifications/beacon/AEIlDqOIU227QspoBB6d-60x_00l4XB4ks5sZpR3gaJpZM4Ouf2m.gif

robertoostenveld commented 7 years ago

I can imagine your observation being relevant depending on the TTL-to-USB converter. I only used it with a Wemos D1 Mini, which has a CH340.

I had one other user of this code reporting that it did not work for him. Your observation may solve his problem as well, and I am willing to give it a try. So, please do send a PR.

On 19 Aug 2017, at 19:25, cmoore42 notifications@github.com wrote:

I’ve got some other changes too – I can send them to you if want.

I found that, at least on my NodeMCU, the “break” wasn’t working. The code switches baud rate to 57600 and sends a 0, which seems like it should work, but I was still getting only about 40 us of low for the break. I added a C++ function to access the ESP8266 uart function and generate a break that way, and it works for me now.

Let me know if you’d like a pull request for that change.

Chris

From: Robert Oostenveld [mailto:notifications@github.com] Sent: Saturday, August 19, 2017 12:53 AM To: robertoostenveld/arduino arduino@noreply.github.com Cc: cmoore42 chrismoore@surewest.net; Author author@noreply.github.com Subject: Re: [robertoostenveld/arduino] Added an option to use a common anode RGB LED. (#1)

thanks, makes sense!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/robertoostenveld/arduino/pull/1#issuecomment-323507918 , or mute the thread https://github.com/notifications/unsubscribe-auth/AEIlDuc25kisn0-S0p5mysfJZlMeMy53ks5sZpR3gaJpZM4Ouf2m . https://github.com/notifications/beacon/AEIlDqOIU227QspoBB6d-60x_00l4XB4ks5sZpR3gaJpZM4Ouf2m.gif

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.