search

robertoostenveld / esp8266_artnet_dmx512

56 stars 11 forks source link

I2s documentation #5

Closed apdlv72 closed 1 year ago

apdlv72 commented 1 year ago

Did as you suggested: Created a new branch i2s_documentation. Created a pull request from your main branch to the new one. Resolved merge conflicts, committed, pushed. Now craeted a new pull request from my new branch to your master. I hope it worked better this time. BTW - I included also some simplifications to the anode/cathode handling in order to reduce code. I leave it up to you if you want to merge those changes as well.

robertoostenveld commented 1 year ago

thanks, and your anode/cathode handling is way more elegant!

apdlv72 commented 1 year ago

Thank you, too. BTW - I gave the code a stress test some days ago by firing lots of requests in a loop with curl while running a light show on some devices. I did not find any issues at first sight. I forgot however to check if this affected the frame rate. I will do so on the weekend and keep you posted

On Wed, 2 Nov 2022, 22:43 Robert Oostenveld, @.***> wrote:

thanks, and your anode/cathode handling is way more elegant!

— Reply to this email directly, view it on GitHub https://github.com/robertoostenveld/esp8266_artnet_dmx512/pull/5#issuecomment-1301337359, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLLPXJRGJUKJOJFUCOS42LWGLOA7ANCNFSM6AAAAAARVRD2JE . You are receiving this because you authored the thread.Message ID: @.***>

apdlv72 commented 1 year ago

Removed documentation only branch