refactor(pages): simplify page lifecycle removing the redundant concept of visibility

robertpsoane / ducker

A slightly quackers Docker TUI based on k9s 🦆

https://crates.io/crates/ducker

MIT License

261 stars 11 forks source link

Closed robertpsoane closed 3 months ago

robertpsoane commented 3 months ago

In the first pass of the Containers and Images pages, there was a concept of "visibility"; this was before the Page trait had been added
This removes the concept of visibility (and the corrolorary call to initialise
Instead there is a single initialise method
Where clean-up is required for a page, there is a Close trait that must be implemented by all Pages
The close method has a default behaviour, this could go in a simple procedural macro with time but for now it just falls back on the default behaviour where no clean-up is requried for the page

codecov[bot] commented 3 months ago

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.