search

robertraaijmakers / com.trashchecker

Trashcan Reminder 2.0 is an app for Homey (Home Automation Hub) and gives you the ability to get notifications when your trash is being collected.
10 stars 30 forks source link

Afvalwijzer does not work #45

Closed jeroenvano closed 5 years ago

jeroenvano commented 5 years ago

The app gives an error saving the postcode and house number "Dit adres wordt niet ondersteund" on the mijnafvalwijer.

On the website of mijnafvalwijer the postcode and house number work.

This app used to work but it seems that after an update it stopped working for my address.

Postcode 5345

fspaan commented 5 years ago

What I tried to do Installed Afvalwijzer 2.0 for Homey 2.04. I entered postcode and housnumber with source: 'Mijn Afvalwijzer'. However, I received an error message: 'Dit adres wordt niet ondersteund'. Upon checking the website mijnafvalwijzer, I noticed the postcode has to be entered in the following format <9999>[blank spac]. (Example 1234 AA). I noticed that the field does not support this in the configuration of the Homey App.

Steps I have taken Installed Afvalwijzer 2.04. Chose 'Configureer App', Entered postode 1234AA, housnumber 1 (example), country NL, source: Mijn Afvalwijzer.

System I use Homey 2.04, Afvalwijzer 2.0. (Previously I used the 1.5 version.

Advise Please check entryfield Postcode. In the homeyapp a different format is required and does not match the format of Mijnafvalwijzer. In the Homey App: Format: 1111AA In the Afvalwijzer: format: 1111 AA

Thanks

AnonymousMiz commented 5 years ago

Diagnostic report code: ac1bca21-00a3-449d-b33e-20b98754ea05

Veldkornet commented 5 years ago

I have the same issue.

Although on the website, the space in the postcode make no difference for me, both work.

uNiiek commented 5 years ago

I also have the problem with "Mijn Afvalwijzer"

A333333 commented 5 years ago

Me too, “dit adres wordt niet ondersteund” but website Afvalwijzer works. Also the data which is already collected is correct. But no triggers are working. It was working before. It always worked like it is supposed to be.

larsnet commented 5 years ago

Same issue

maikrovers commented 5 years ago

There is defenitly an issue with the app. I receive the same message.

robertraaijmakers commented 5 years ago

All, sorry for not replying earlier. I'm currently not able to investigate this. I'm will happily accept a pull request and push that to the Athom store when someone provides a fix.

Veldkornet commented 5 years ago

I've found the issue, tested it and submitted pull request #48 for a fix. It's running fine now on my Homey.

A333333 commented 5 years ago

Hi Robert,

I honestly don’t know if it is suddenly only https. I just select the proper waste calender. I cannot adjust it in something else because it is coded.

I forgot my wastebins already 1 time since Homey could not tell me to put the containers to the collection point...

I think this needs some work in your app?

Thanks in advance and for your good work so far!

Verstuurd vanaf mijn iPhone X

Op 22 mrt. 2019 om 18:02 heeft Veldkornet notifications@github.com<mailto:notifications@github.com> het volgende geschreven:

Is it possible that it’s because the app is requesting via HTTP but the site is now in HTTPS by default? I don’t know if it has always been this way...

I looked in your code and saw that you use http://www.mijnafvalwijzer.nl/nl/

But if I just do a simple cURL to that URL, I get a 301 permanently moved. But if I do a cURL to https://www.mijnafvalwijzer.nl/nl/ Then I get a 200OK response.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/robertraaijmakers/com.trashchecker/issues/45#issuecomment-475699995, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AnWO1jn8dHY5Ax4mR5lfCDhqCG4wWyAtks5vZQzBgaJpZM4bRDBa.

robertraaijmakers commented 5 years ago

Thanks to @Veldkornet a new version of the app is submitted to Athom. After review it will soon hit the store as beta and when feedback is good I will push it to master.

larsnet commented 5 years ago

I installed the beta from the app store. Afvalwijzer is working for me again , Thanks!

robertraaijmakers commented 5 years ago

2.5.3 is released as public version. Should all work now. Closing this issue.