search

robertrossmann / vscode-remedy

A VS Code theme with orange accents with roots in Base16 - Eighties colour theme
https://marketplace.visualstudio.com/items?itemName=robertrossmann.remedy
BSD 3-Clause "New" or "Revised" License
62 stars 4 forks source link

Integration for .pug/jade? #17

Closed dcorso21 closed 3 years ago

dcorso21 commented 3 years ago

Hi there,

First, let me just say I love this theme. Thank you for all the work you've put into it!

I've been using It for some front end stuff and noticed that the theme doesn't quite gel with PUG/JADE and thought it might be something you would like to be aware of. When using PUG with remedy, the class names and id names are the same color as the body text, making it very hard to differentiate between tags, classes and content.

It would be great if this feature was included in Remedy! I hope you will consider implementing it.

Thank you again for making this theme!

David

dcorso21 commented 3 years ago

Screen Shot 2020-10-19 at 12 41 17 PM

Here is a photo I should have included of the effect — using remedy dark tilted

robertrossmann commented 3 years ago

Hi @dcorso21, thanks for the suggestion! Indeed, that looks most...flat and boring!

I did some basic research and while it might be fixable to some extent, the built-in Pug parser is rather basic and does not provide a lot of flexibility in terms of selecting specific elements of the language and theming them. 🤷‍♂️ So yeah, the classes and IDs should be themeable but unless I did something wrong, applying the colouring also affected the element's properties (the things that are in the brackets after the element, ie. img(things)), so mostly everything was red instead of white. 🤦‍♂️

I'll see what I can do... Unless you are up for a challenge and would like to send a PR? 😇

dcorso21 commented 3 years ago

I would be happy to take a look - however, I'm a new developer and the complexity of the codebase is a little out of my depth. -- fair warning!!

robertrossmann commented 3 years ago

No worries, I'll take care of this myself, it just might take a while as I'm a bit busy on an actual, paid, work. 😂 I do try to make regular updates and improvements, though.

dcorso21 commented 3 years ago

Of course! No pressure at all! I appreciate you taking the time to consider it. Like I said, I'm a big fan of the theme. Thanks for sharing it with vscode users!

github-actions[bot] commented 3 years ago

:tada: This issue has been resolved in version 5.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: