robertrossmann / vscode-remedy

A VS Code theme with orange accents with roots in Base16 - Eighties colour theme
https://marketplace.visualstudio.com/items?itemName=robertrossmann.remedy
BSD 3-Clause "New" or "Revised" License
63 stars 4 forks source link

Possibility to customize base color #36

Closed gsabater closed 9 months ago

gsabater commented 11 months ago

Hello,

First of all, amazing theme. I have been using it for over two years. Today I felt something wasn't right and i have seen on the changelog the changes of the f419551 commit

The base color in dark variant feels too orange for me. And i liked better before. Of course, i have installed the 5.17 version of the extension and solved the problem, but i'd like to ask if it would be possible to have the old base color in some way, via configuration values or something, so i dont have to lock myself on the v5.17

Thanks a lot for your work, is amazing.

gsabater commented 11 months ago

Looking at other issues, i have seen we can set something like

"editor.semanticTokenColorCustomizations": {
  "[Remedy - Dark (Tilted)]": {
    "rules": {
      "variable.readonly": "#F9E7C4",
      "property.readonly": "#F9E7C4"
    }
  }
}

Can you guide me on what values can i set to have the background as it was? Thanks

singularitti commented 9 months ago

The base color in dark variant feels too orange for me. And i liked better before.

Same here! The current color seems very reddish on macOS retina screen. I hope we could configure it.

robertrossmann commented 9 months ago

Hey guys! Thanks for the feedback! I made those changes because I felt that the neutral grey everywhere started to look too boring and I wanted to "spice it up" a little bit. 🤷‍♂️

Unfortunately, the way the theme colours propagate to other parts of VS Code UI when this theme is built it is going to be extremely difficult to continue using the newest version of Remedy while preserving the grey background or the whiter text colours. There are simply too many references to that colour and while you could theoretically revert some UI elements to the old variant it's never going to look as awesome and consistent as it used to.

If you really want to try at least something, the best thing you could do is to clone this repo, open the file with UIPallette interface and find all references of the colour you'd like to revert:

Screenshot 2024-02-07 at 11 42 21

Then, go through all occurrences (or only those relevant to you) of that colour property in the mkui.ts file and place the VS Code colour customisations into your settings with the old colour.


In the future, I would like to implement a way to keep the "legacy" look still available as a separate theme when I decide it's time for an overhaul again but right now it's just too much work to do that and the repo would need some extra love to make that work manageable.

I hope this will help you at least somewhat. Anyway, two years of using Remedy?! That's more than I ever hoped for when I first released the theme. ❤️