search

robertrossmann / vscode-remedy

A VS Code theme with orange accents with roots in Base16 - Eighties colour theme
https://marketplace.visualstudio.com/items?itemName=robertrossmann.remedy
BSD 3-Clause "New" or "Revised" License
63 stars 4 forks source link

Terminal text unreadable on mouseover when terminal sticky scroll is on #40

Closed mitsukuri closed 1 month ago

mitsukuri commented 1 month ago

First of all, Robert, I'd like to thank you for this wonderful tasteful theme, it is just perfect. Whenever I think I got tired and go trying other themes, I would return to Remedy in just a few minutes :)

Now to the issue: When the sticky scroll is enabled for terminal (terminal.integrated.stickyScroll.enabled: true, introduced in VS Code 1.85) and the command in the sticky header is getting a mouseover event, it becomes unreadable. Which does not occur with other themes.

Here's Remedy: https://github.com/user-attachments/assets/b0ba2751-b396-457a-9030-e70c7fdc0773

And here's default Light https://github.com/user-attachments/assets/824347d4-26f3-4a3a-b922-f71dbb52fb96

VS Code 1.93.1 Remedy 5.25.0

robertrossmann commented 1 month ago

Ugh, that looks awful, I'll take a look. And thanks for the kind words, happy that you like it! ❤️

github-actions[bot] commented 1 month ago

:tada: This issue has been resolved in version 5.25.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

mitsukuri commented 1 month ago

Thank you so much fox the fix!