The property is displayed as a string color.

robertrossmann / vscode-remedy

A VS Code theme with orange accents with roots in Base16 - Eighties colour theme

https://marketplace.visualstudio.com/items?itemName=robertrossmann.remedy

BSD 3-Clause "New" or "Revised" License

62 stars 4 forks source link

The property is displayed as a string color. #8

Closed CatsMiaow closed 4 years ago

CatsMiaow commented 4 years ago

Remedy - Dark

One Dark Pro

When using template literals, the colors of id and content are different and are the same as the string colors. Is it intended?

robertrossmann commented 4 years ago

Thanks for the report! I have not noticed this myself yet, I’ll check this as soon as I get to a computer.

Are you perchance using the new experimental semantic highlighting functionality (editor.semanticHighlighting.enable needs to be turned on, I believe) ? It messes up the colour scheme real bad at this time... 🤷‍♂️

robertrossmann commented 4 years ago

Unfortunately I cannot reproduce this on my side. Could you please place your cursor onto the id (ideally between the i and d), open up the token inspector hover (Developer: Inspect Editor Tokens and Scopes in the command palette) and send me a screenshot of that? 🙏 It looks like this:

CatsMiaow commented 4 years ago

"editor.semanticHighlighting.enabled": false

"editor.semanticHighlighting.enabled": true

semanticHighlighting is using the default value (false).

CatsMiaow commented 4 years ago

Found the cause. This is a problem with Microsoft extensions. https://marketplace.visualstudio.com/items?itemName=ms-vscode.typescript-javascript-grammar https://github.com/Microsoft/TypeScript-TmLanguage

Disable the extension solved the problem. Thank you.

robertrossmann commented 4 years ago

Ah okay, good! I was a little curious as to why that .id property was being classified as something DOM-related... 🤷‍♂ Thanks for reporting the issue, though!