search

robertsLando / node-red-contrib-m-bus

Node-Red node for M-Bus protocol
MIT License
10 stars 6 forks source link

chore: bump node-mbus@2.1.0 #40

Closed petrkr closed 4 months ago

petrkr commented 4 months ago

Build on actual LTS NodeJS 20 and actuall nodejs ends with error. It uses historical version of node-mbus, so simple update to latest 2.1.0 version helped

npm ERR! In file included from ../../nan/nan.h:176,
npm ERR!                  from ../src/main.cc:1:
npm ERR! ../../nan/nan_callbacks.h:55:23: error: ‘AccessorSignature’ is not a member of ‘v8’
npm ERR!    55 | typedef v8::Local<v8::AccessorSignature> Sig;
npm ERR!       |                       ^~~~~~~~~~~~~~~~~
npm ERR! ../../nan/nan_callbacks.h:55:40: error: template argument 1 is invalid
npm ERR!    55 | typedef v8::Local<v8::AccessorSignature> Sig;
npm ERR!       |                                        ^
npm ERR! In file included from ../src/main.cc:1:
npm ERR! ../../nan/nan.h: In function ‘void Nan::SetAccessor(v8::Local<v8::ObjectTemplate>, v8::Local<v8::String>, Nan::GetterCallback, Nan::SetterCallback, v8::Local<v8::Value>, v8::AccessControl, v8::PropertyAttribute, Nan::imp::Sig)’:
npm ERR! ../../nan/nan.h:2549:16: error: no matching function for call to ‘v8::ObjectTemplate::SetAccessor(v8::Local<v8::String>&, void (*&)(v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Value>&), void (*&)(v8::Local<v8::Name>, v8::Local<v8::Value>, const v8::PropertyCallbackInfo<void>&), v8::Local<v8::Object>&, v8::AccessControl&, v8::PropertyAttribute&, Nan::imp::Sig&)’
npm ERR!  2549 |     , signature);
npm ERR!       |                ^
npm ERR! In file included from /opt/nodered/.cache/node-gyp/20.11.1/include/node/v8-function.h:15,
npm ERR!                  from /opt/nodered/.cache/node-gyp/20.11.1/include/node/v8.h:33,
npm ERR!                  from /opt/nodered/.cache/node-gyp/20.11.1/include/node/node.h:73,
npm ERR!                  from ../../nan/nan.h:56,
npm ERR!                  from ../src/main.cc:1:
petrkr commented 4 months ago

Sorry I am not familiar with NodeJS system, from documentation I read lock file is generated on install, so I do not understand why It must be in repository as it is dynamically generated file.

I tested it on my instance where I did also npm install

petrkr commented 4 months ago

Hello' force pushed new version, so it will not do extra commits. This is right ?

Regards Petr

robertsLando commented 4 months ago

@petrkr Just released 3.1.0 version