robertvazan / sourceafis-java

Fingerprint recognition engine for Java that takes a pair of human fingerprint images and returns their similarity score. Supports efficient 1:N search.
https://sourceafis.machinezoo.com/java
Apache License 2.0
245 stars 100 forks source link

Expose minutiae details #35

Closed saroehr closed 4 years ago

saroehr commented 4 years ago

Would it be possible to expose the "minutiae" information in some meaningful way on the FingerprintTemplate? We have a need to render minutiae information as an overlay onto the fingerprint image itself. It appears this information is inside the Immutable object, but that object is unvailable for reading data from. Perhaps some form of the minutiae information could be exposed externally to a caller or available via subclass?

robertvazan commented 4 years ago

You can parse the serialized template:

https://sourceafis.machinezoo.com/template

There is also a library that does the parsing for you (undocumented at the moment):

https://github.com/robertvazan/sourceafis-transparency-java

And there's even a library that does the visualization for you (undocumented too):

https://github.com/robertvazan/sourceafis-visualization-java

saroehr commented 4 years ago

Hi Robert!

Yes we are parsing the serialized template but this is a large amount of overhead to get this information it seems as we first must deserialize the template from the image to then serialize it and then then deserialize it again to parse the information from the immutable that contains it. This seems unnecessary and makes the dependent upon knowing the serialized form which is subject to changes as you mention.

Thank you for your reply. I inherited this code and if there is a better way to do this that is great! I will review the transparency topic more to see if I can figure out why it isn’t providing everything the developer needed.

Thanks!

Scott


From: Robert Važan notifications@github.com Sent: Wednesday, August 5, 2020 3:59:31 AM To: robertvazan/sourceafis-java sourceafis-java@noreply.github.com Cc: Scott Roehrig saroehr@hotmail.com; Author author@noreply.github.com Subject: Re: [robertvazan/sourceafis-java] Expose minutiae details (#35)

Closed #35https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frobertvazan%2Fsourceafis-java%2Fissues%2F35&data=02%7C01%7C%7Cb93c4e81c78d497bac6408d8391ddece%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637322147733825198&sdata=OFhnRPdalSmWb4C6NwGfuS7m2w%2Fow05LyHbe5pHkK2A%3D&reserved=0.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frobertvazan%2Fsourceafis-java%2Fissues%2F35%23event-3623714629&data=02%7C01%7C%7Cb93c4e81c78d497bac6408d8391ddece%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637322147733835180&sdata=n9QrYanYYnF7w9CUdQX3gnUlxIFlQC2cK9U6muLgb8Y%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFAJWWTZKTO453N36QJS4QDR7ENPHANCNFSM4PUVSTJA&data=02%7C01%7C%7Cb93c4e81c78d497bac6408d8391ddece%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637322147733845171&sdata=G8vw63jZhqaEjm%2F6dby1ZbHNTmwjDZf1T4qM1H9aN9k%3D&reserved=0.

robertvazan commented 4 years ago

Template serialization/deserialization is fast, especially with the new CBOR format. Only feature extraction is expensive.

saroehr commented 4 years ago

That is good to know that the serialization is fast. But we still have to turn around and re-read it back from the serialized template.. Is there a reason that the template information could not be exposed to avoid that second round trip step? It also makes our code brittle if the template form changes we have to update our code that re-reads it. Exposing the details via the API would shield us from that without breaking the functions if the exposed object is read-only.

saroehr commented 4 years ago

Perhaps the need is moot also if I can figure out how to get the information they appear to be desiring from the transparency.

saroehr commented 4 years ago

Thank you Robert.

robertvazan commented 4 years ago

Even API of the transparency library is subject to change with every release. There's a roadmap for stable API for minutia access/editing, so this might be available in the future.