search

robertwayne / axum-htmx

A set of htmx extractors, responders, and request guards for axum.
Apache License 2.0
185 stars 9 forks source link

Vary #15

Closed imbolc closed 6 months ago

imbolc commented 7 months ago

As discussed in #14

robertwayne commented 6 months ago

Other than that one nit, this looks good to go!

Thank you!

imbolc commented 6 months ago

Other than that one nit

Are you referring to something for me to change?

robertwayne commented 6 months ago

Other than that one nit

Are you referring to something for me to change?

Woops, sorry! Yeah, I thought I'd finalized my review!

imbolc commented 6 months ago

It wasn't clear to me whether you wanted me to use type Error = Infallible and ignore the panic possibility or add a new error variant, so I did the latter.

imbolc commented 6 months ago

This one seems ready to merge