robertwb / issues-import-test

0 stars 0 forks source link

Bad code generation #68

Closed robertwb closed 7 years ago

robertwb commented 7 years ago

Reported by gfurnish on 2 Aug 2008 12:08 UTC

 147:             x = <TypedSymbolicExpression>PyList_GET_ITEM(operands, i)

      Py_INCREF(((PyObject *)((struct __pyx_obj_4sage_9symbolics_10expression_TypedSymbolicExpression *)PyList_GET_ITEM(__pyx_v_operands, __pyx_v_i))));
      Py_DECREF(((PyObject *)__pyx_v_x));
      __pyx_v_x = ((struct __pyx_obj_4sage_9symbolics_10expression_TypedSymbolicExpression *)PyList_GET_ITEM(__pyx_v_operands, __pyx_v_i));

This should use a temporary instead of calling the thing being casted twice.

Migrated-From: http://trac.cython.org/ticket/36

robertwb commented 7 years ago

Comment by robertwb on 3 Aug 2008 05:39 UTC See http://hg.cython.org/cython-devel/rev/def99eb4f83c

robertwb commented 7 years ago

Modified by robertwb on 19 Aug 2008 04:35 UTC