robertzak133 / unified-btc-reverse

Unified Repository for all Browning Trail Camera Reversing
5 stars 0 forks source link

Setting time to 24h format ignores any PM #8

Open hunnymonster opened 3 months ago

hunnymonster commented 3 months ago

What do I mean exactly? Hmmm...

Image the camera is set to 12h AM/PM time format and the time is 3:45PM - if I set the time format to 24h the clock appears to be reset to 03:45 (ie. 3:45am ignoring the 12h extra for PM)

Based on a sample size of 1 - on a BTC-7E-HP5 using the latest (as I type this) that's the 0605 firmware.

Might be worth mentioning it in release notes for those that don't check before putting the camera out with operation hours set and accidentally end up with the time set 12h wrong capturing zero action.

robertzak133 commented 3 months ago

Oops. I can see how this might happen. That part of the code is a little convoluted, and I had to struggle a little to get it into its current "almost working" state. I should be able to fix this. Thanks for filing issue.

hunnymonster commented 3 months ago

Honestly @robertzak133 I should have checked the time was correctly set - but if it is straightforward to resolve even better. A caveat in the release notes would also suffice.

robertzak133 commented 1 week ago

@hunnymonster can you provide a detailed button sequence of an example of this bug? I am recently back into the code and ran several variations of the recipe in the initial report and am unable to reproduce. I am probably missing some, seemingly trivial step, but which is the pre-cursor of the bug.

hunnymonster commented 1 week ago

Oh sweet mercy! I can barely recall what I did yesterday... From (hazy) memory I believe that I took the fresh camera out of the box, set it up in the woods with an active recording window of dusk to daybreak(ish), used it for a day or two then applied your enhanced firmware.

I set the date & time - which is obviously wiped as part of the application of new firmware.

Then I set the date format to the most rational 'big endian' YYYY-MM-DD and the time to 24h (this was carried out at approx 13:45 from memory. Reset the recording window to dusk(ish) to dawn(ish) & put it back in the woods

The next day when I collected the card it had nothing recorded on it... Upon checking the camera I discovered the time to be exactly 12h slow leading to the potential conclusion that the AM/PM marker had been discarded/ignored when changing the time format.

robertzak133 commented 2 days ago

Sorry for the demanding ask. I might have more tactfully asked, “do you remember the sequence of operations you ran through all that time ago?” :) But, in any case, you did. Your recipe included setting up the recording window with the “capture timer” feature, which I hadn’t considered before.

None-the-less, when I finally got the point of testing, I went through the steps above (and many others) and I could not reproduce the problem. If this bug crops up again, please do let me know.

hunnymonster commented 1 day ago

Will do. But you could just add a caveat to the instructions with the possibility of this happening.

robertzak133 commented 1 day ago

Yes, I suppose that would be a good idea :) Thanks.