search

robertzk / cachemeifyoucan

An R caching layer
MIT License
7 stars 7 forks source link

Add utility to update salt for caches #117

Closed khalidharun closed 8 years ago

khalidharun commented 8 years ago

This PR allows for cached functions to use an updated salt, which affects the table_name and shard_names.

  1. New shards will be created by copying data from old_shards.
  2. Add new indexes for the new shards.
  3. Add new entries into the table_shard_map.

Note: There was a previous method that allowed for updating salts but it led to more complications.

khalidharun commented 8 years ago

@peterhurford @kirillseva Can you review this? Wrote a nice test for this also.

kirillseva commented 8 years ago

Code looks good!

robertzk commented 8 years ago

@khalidharun Nice! LGTM.

peterhurford commented 8 years ago

Looks good. Obviously be careful about how you use this. ;)

khalidharun commented 8 years ago

@robertzk This is good to merge! (yay)

robertzk commented 8 years ago

Love it!

kirillseva commented 8 years ago

shipit!