search

robertzk / lockbox

Bundler-style dependency management for R
MIT License
49 stars 11 forks source link

Cache github by ref (if provided as ref) #123

Closed russellpierce closed 7 years ago

russellpierce commented 7 years ago

The purpose of this PR is to reduce the number of times a useR experiences a stale cache as a consequence of switching between github and some other repository source when the stated version is identical.

I understand the preference would be that on every commit people update their version. I don't have control over all people though. In practice, under semantic versioning with a x.y.z versioning scheme you wouldn't even expect z to increment for every ref. Even if you had x.y.z.build, in practice people will forget to increment.

I know @peterhurford has misgivings about this approach. With respect, lacking feedback from additional contributors, I wanted to raise the profile of the proposal by opening a PR to collect some additional thoughts and feedback.

Issue where this has been discussed (although this PR does not close that issue): https://github.com/robertzk/lockbox/issues/99

peterhurford commented 7 years ago

Hi @russellpierce. Thanks for the thoughtful PR. I don't know about @kirillseva or @robertzk but I'm pretty busy this week, so there is going to unfortunately be silence from me for a little bit. I look forward to hopefully looking and thinking this over next week.

robertzk commented 7 years ago

@russellpierce Thank you for the PR! I've left some comments in the original thread. I'm comfortable merging this but proposed an alternative approach we should discuss first.