search

robertzk / lockbox

Bundler-style dependency management for R
MIT License
49 stars 11 forks source link

package:jsonlite used in devtools_substitutes.R but not in Imports or Suggests #129

Closed russellpierce closed 6 years ago

russellpierce commented 6 years ago

As the title says... is this okay? It seems to annoy CMD CHECK.

peterhurford commented 6 years ago

I think it's "okay" as in the package will still be functional, but it is not desirable from stability and maintainability standpoints. We should fix it.

russellpierce commented 6 years ago

Alright. Sounds good. jsonlite doesn't look too add any upstream dependencies so it shouldn't be a big deal. https://github.com/jeroen/jsonlite/blob/master/DESCRIPTION I'll probably be poking around in this codebase later this week. If nobody else jumps on it, then I'll fix it.

robertzk commented 6 years ago

Thanks @russellpierce , good point. Fixed here. Feel free to re-open the issue if R CMD CHECK isn't happy.