search

robertzk / lockbox

Bundler-style dependency management for R
MIT License
49 stars 11 forks source link

Support versionless package references #133

Open eeevayu opened 6 years ago

eeevayu commented 6 years ago

It should be possible to emit a CRAN-dependency, using something like:

- 
  name: dplyr

instead of 

- 
  name: dplyr
  version: 0.9.6

One can solve the problem of checking CRAN on startup every time by caching the latest timestamp in the ~/.R/lockbox directory, and only checking once every N hours (can be a global options like lockbox.check_dependency_versions_interval, by default 1 hour).

Just a friendly suggestion. :)

russellpierce commented 6 years ago

I've got some changes stranded off on https://github.com/zapier/lockbox which can do something much like this. Unfortunately I haven't been able to prioritize bringing back here yet. :/

robertzk commented 5 years ago

@russellpierce No worries. Let me know when you want to collaborate on this. I should have some dev bandwidth this month. :)

russellpierce commented 5 years ago

@robertzk I'm trying to remember where I left off with this... it is pretty fuzzy.
https://github.com/robertzk/lockbox/compare/master...zapier:prod is the current state of things. It looks like maybe I resolved some of the conflicts that had cropped up but then not gotten around to cleaning up, re-testing, and setting up a new PR. I think there were two hangups.

The first relates to https://github.com/robertzk/lockbox/issues/130. I think poking around that issue lead to my edits to R/library.R, but I don't remember the details.

The second was that I hacked my solution together inelegantly and then ran into a 🤦‍♂️ about not using get_available_cran_version() in my handling of fixing the issue. But, my patch was working and it was time to move on.

robertzk commented 5 years ago

Thanks for reviving this! I will revisit it later this week after a sprint deadline coming up Friday. I appreciate the action.

On Wed, Oct 10, 2018 at 11:16 PM Russell S. Pierce notifications@github.com wrote:

@robertzk https://github.com/robertzk I'm trying to remember where I left off with this... it is pretty fuzzy. master...zapier:prod https://github.com/robertzk/lockbox/compare/master...zapier:prod is the current state of things. It looks like maybe I resolved some of the conflicts that had cropped up but then not gotten around to cleaning up, re-testing, and setting up a new PR. I think there were two hangups.

1 https://github.com/robertzk/lockbox/issues/1 relates to #130

https://github.com/robertzk/lockbox/issues/130. I think poking around that issue lead to my edits to R/library.R, but I don't remember the details.

2 https://github.com/robertzk/lockbox/issues/2 The second was that I

dirty hacked my solution together and then ran in to a 🤦‍♂️ about not using get_available_cran_version() in my handling of fixing the issue. But, my patch was working and it was time to move on.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/robertzk/lockbox/issues/133#issuecomment-428833763, or mute the thread https://github.com/notifications/unsubscribe-auth/ABkAXN4_8a0b3AmhYscszfrFrqFtIIuWks5ujuItgaJpZM4V4kwp .

-- -Robert Krzyzanowski

russellpierce commented 5 years ago

@robertzk Happy (US) Thanksgiving. I'm thankful for this package. I was doing some cleanup of my other code and remembered this issue. Thought I'd check in. :)

robertzk commented 5 years ago

Thanks @russellpierce ! Happy Thanksgiving to you as well. I had the intentions but with a geographic relocation and product deadline EOY I will not have the bandwidth to tend to this. If there's a specific PR to review I'd be happy to take a look!