search

robfig / glock

MIT License
230 stars 27 forks source link

save: remove repoRootForImportPath #35

Closed tamird closed 8 years ago

tamird commented 8 years ago

This greatly speeds up glock save. Closes #25.

Before:

$ time glock save github.com/cockroachdb/cockroach

real 0m59.388s user 0m7.946s sys 0m3.877s

After:

$ time glock save github.com/cockroachdb/cockroach

real 0m3.729s user 0m7.353s sys 0m3.442s

tamird commented 8 years ago

@robfig ping.

robfig commented 8 years ago

That seems quite desirable, but is there functionality that we lose with this change?

tamird commented 8 years ago

I didn't pour over the code - I simply went by your suggestion in #25.

robfig commented 8 years ago

Ah, forgot about that. As long as you've tested and everything's good.. Thanks!