search

robfig / glock

MIT License
230 stars 27 forks source link

save: only save our roots' test imports #38

Closed tamird closed 7 years ago

tamird commented 8 years ago

This transitively avoids saving test imports, except for those which are directly imported by the target package or its subpackages.

tamird commented 8 years ago

cc @raduberinde @irfansharif @tschottdorf

RaduBerinde commented 8 years ago

LGTM. The only question is if other projects might need the old behavior (for whatever reason, e.g. maybe they run tests for some dependencies), in which case we may need a flag. Easy enough to add later if indeed necessary though.

tamird commented 8 years ago

TFTR! Let's see what @robfig has to say.

jmoiron commented 7 years ago

Update on this? I am using @tamird's fork as I don't want to pull in every pet test framework and alternate libs for compatibility testing.

robfig commented 7 years ago

Lovely, thank you