robfig / glock

MIT License
230 stars 27 forks source link

Updated downloadCmd for git to also fetch tags. #46

Closed bjulian5 closed 5 years ago

bjulian5 commented 5 years ago

git pull --ff-only does not pull all tags. It will only pull tags where the ref exists on the master branch. Because of this, glock sync will fail if the ref only exists on a tag that doesn't exists locally.

Without this change, if a user pins to a ref that only exists on tag that doesn't exists locally, they will either need to run git fetch --tags or delete the repo and have glock downlaod the repo again.

All this change does is modify the download command to also pull tags in order to avoid the scenario above.

45

robfig commented 5 years ago

Thanks!