robfig / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 1 forks source link

Subsequent patch sets with fewer files than earlier ones could list the missing files #146

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
I have this code review with four snapshots:
  http://gwt-code-reviews.appspot.com/57812/show

In patch set 1 (but not in patch set 2) this file is included:
  samples/i18n/war/I18N.html

What is the expected output? What do you see instead?
In this case myself (the patch submitter) and the reviewer missed this 
unintentional omission.

It would be really useful IMO if the panel/view for patch set 2 indicated 
which files were not present in 2 but were a part of patch set 1.

Proposal in this case would be an additional entry under patch set 2 with:
  Unified diffs: samples/i18n/war/I18N.html <--- not a hyperlink
  Side by side diffs: N/A
  Delta from patch set: 1
  Stats: - - -
  Download raw patch set: -  <----- nothing to see here

What version of the product are you using? On what operating system?
r417

Please provide any additional information below.

Original issue reported on code.google.com by fredsa on 27 Aug 2009 at 12:12

GoogleCodeExporter commented 9 years ago
Related issue 147:
  http://code.google.com/p/rietveld/issues/detail?id=147

Original comment by fredsa on 27 Aug 2009 at 12:18

GoogleCodeExporter commented 9 years ago

Original comment by albrecht.andi on 6 Apr 2012 at 7:41