robfig / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 1 forks source link

Word-wrapping is mangled in codereview.chromium.org #171

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Steps to reproduce in codereview.chromium.org:
 * Enter a long line of text into a code review comment without pressing Enter.
 * Send the message.

Expected behaviour:  In the resulting e-mail, either the line is not
word-wrapped at all (leaving it to the mail reader to wrap), or it is
wrapped at a sensible number of columns (perhaps 80).

Actual behaviour:  Rietveld appears to wrap the line twice (the second time
with a smaller width), which mangles it.

For example, in a post in this thread -
http://groups.google.com/group/native-client-reviews/browse_frm/thread/f7ca5b50d
29544ab
one of my comments got wrapped as:

"""
This should actually be bool but not sure if we have that available  
portably in
C.  Changed to int8_t for now.
"""

It looks like Rietveld wrapped the line once to split on "C." and then a
second time, splitting "portably in" onto a separate line.

This makes the resulting e-mails look really bad!

I don't know which Rietveld version codereview.chromium.org is currently using.

Original issue reported on code.google.com by mseaborn@chromium.org on 25 Nov 2009 at 10:28

GoogleCodeExporter commented 9 years ago

Original comment by albrecht.andi on 6 Apr 2012 at 7:25