search

robfig / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 1 forks source link

[Feature request] Better copy pasting support #506

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
STEPS TO REPRODUCE
1- Open a Rietveld issue. For example 
https://codereview.chromium.org/120753002/.
2- View a unified diff of a file. For example: 
https://codereview.chromium.org/120753002/diff/370001/base/metrics/statistics_re
corder.h
3- Try to copy the right part of the comment that has a diff.

WHAT HAPPENS
https://screenshot.googleplex.com/AiiTOGmA7U
Selection spans across both sides, selecting something like:

// GetSnapshot copies some of the pointers to registered histograms into the
  73   // caller supplied vector (Histograms).  Only histograms with names matching   73   // caller supplied vector (Histograms). Only histograms which have |query| as
  74   // query are returned. The query must be a substring of histogram name for its     74   // a substring are copied (an empty string will process all registered
  75   // pointer to be copied.   75   // histograms).

WHAT SHOULD HAPPEN
Selection only selects the left or the right text, and also doesn’t select 
the numbers or any other spacing.

Selection should be:
// GetSnapshot copies some of the pointers to registered histograms into the
  // caller supplied vector (Histograms). Only histograms which have |query| as
  // a substring are copied (an empty string will process all registered
  // histograms).

Original issue reported on code.google.com by lpromero@chromium.org on 30 Sep 2014 at 2:26