search

robfig / soy

Go implementation for Soy templates (Google Closure templates)
MIT License
172 stars 41 forks source link

i18n vs master? #61

Closed mhupman closed 6 years ago

mhupman commented 6 years ago

Of the recent merged PRs, some are merged into master and others into i18n. Is there a preferred target? Is there a reason i18n needs to remain out of master or can we consider merging them and using master moving forward? cc @theothertomelliott @angelaxu1

robfig commented 6 years ago

Merging them sounds pretty great. I imagine they were separate to isolate master from the development, and there was no finish line for when to merge them.

Are there any backwards incompatible changes?

mhupman commented 6 years ago

I'm not sure if there are any backwards incompatible changes - can you think of anyway to test? I took a look at the merge locally and the conflicts were few and looked easily resolvable (mostly due to the recent errortype changes)

robfig commented 6 years ago

Yeah in that case merging it sounds good

mhupman commented 6 years ago

Handled in #63