robfig / soy

Go implementation for Soy templates (Google Closure templates)
MIT License
172 stars 41 forks source link

Add dep versioning and update tested Go versions #73

Closed mbrukman closed 4 years ago

mbrukman commented 4 years ago

Fixes #72

mbrukman commented 4 years ago

Looks like the Go 1.11 build failed because one of the transitive dependencies requires a minimum of Go 1.12:

go build golang.org/x/sys/unix: module requires Go 1.12

so I will update the PR accordingly and drop Go 1.11 from the list of tested versions, and will also update go.mod and the README.md to notify users of this, and note the need for GO111MODULE=on as well.

mbrukman commented 4 years ago

Thanks for review + approval, @robfig! The tests are passing; is there anything else you'd like to see before merging?

robfig commented 4 years ago

Nope, merging