search

robfiras / loco-mujoco

Imitation learning benchmark focusing on complex locomotion tasks using MuJoCo.
MIT License
529 stars 43 forks source link

unitreea1_simple perfect datasets downloaded in wrong folder using `loco-mujoco-download` #42

Closed OliEfr closed 4 days ago

OliEfr commented 1 month ago

I noticed this on multiple different machines and fresh installs of loco-mujoco. I looked into the download-code briefly, but couldn't spot the bug so far.

The datasets are not downloaded in

loco-mujoco/loco_mujoco/datasets/quadrupeds/perfect/mini_datasets/unitreea1_simple/

but in

loco-mujoco/loco_mujoco/datasets/quadrupeds/perfect/perfect/unitreea1_simple/perfect_expert_dataset_det.npz

So there is one perfect too much.

This bug lead to an error upon environment creation. When moving the downloaded datasets to the correct path everything works as expected.

robfiras commented 1 month ago

Hi @OliEfr thanks for spotting this. I found the error. It comes from the downloaded datasets. I will fix this in the upcoming version. Your first dataset path is not correct though, it should be: loco-mujoco/loco_mujoco/datasets/quadrupeds/perfect/unitreea1_simple

OliEfr commented 1 month ago

Thanks for fixing.

Indeed, your path is the correct one.

Best,

Oli