search

robfitz / diamondrun

diamondrun
0 stars 0 forks source link

Buffs to attack 7+ crash the game #38

Closed robfitz closed 9 years ago

robfitz commented 10 years ago

Should avoid crashing when a buff raises strength beyond the spritesheet limits

NealKaviratna commented 10 years ago

So do we want the strength to still be able to go above 6, just retain the 6 strength face? Or put a hard limit on how strong any unit in the game can be?

NealKaviratna commented 10 years ago

^Same question for Hp.

robfitz commented 10 years ago

Just throw in a test for out of bounds -- Let the strength go to whatever and leave the face the same for now.

When I was originally playtesting, I wasn't using buffs at all. I like having them in the engine, but I'm not super worried about the edge cases until we have the rest of the gameplay crunchy and have a chance to properly playtest

robfitz commented 9 years ago

Hello again :). How's it all going?

Rob Fitzpatrick

+44 7940435340 +34 602 497 906

Founder Centric http://foundercentric.com/ | Blog http://thestartuptoolkit.com/ | Book http://momtestbook.com/

On Fri, Nov 28, 2014 at 10:02 PM, Neal Kaviratna notifications@github.com wrote:

Closed #38 https://github.com/robftz/diamondrun/issues/38 via fefb8a6 https://github.com/robftz/diamondrun/commit/fefb8a6b4dba407705a6441a92af2920a23355ef .

— Reply to this email directly or view it on GitHub https://github.com/robftz/diamondrun/issues/38#event-200061137.

NealKaviratna commented 9 years ago

Hey! It's been going well. Been a lot busier than I'm used to. but I think I've gotten used to it now!