Regression on a fix regarding propertiesAreEqualToIgnoring and handling nullable ignoringProperties

robfletcher / strikt

An assertion library for Kotlin

https://strikt.io/

Apache License 2.0

558 stars 61 forks source link

Regression on a fix regarding propertiesAreEqualToIgnoring and handling nullable ignoringProperties #299

Open benjaminserguienko opened 9 months ago

benjaminserguienko commented 9 months ago

Hi,

A fix by @jakub-bochenski, that should allow nullable properties in propertiesAreEqualToIgnoring is not working as intended.

We noticed that this commit: c71f66ca505b92ea645e48f77318ec822252f9d4 that should have fixed this issue has not been completely merged in this commit: 02f4226486214b7b2b0f8b751863435b0770439a.

Can you please, fix this ? ty

jakub-bochenski commented 9 months ago

I think its merged in d64444a61dc5f29838b3bf147b79a4a7d7b1a6d0

jakub-bochenski commented 9 months ago

hmm.. indeed it seems the merge is not correct