robftg / Rocket-Launches

Spring 2020 Rocket Launch Project for Pitt Greensburg
1 stars 0 forks source link

Project Checkpoint 3 Website Review #9

Closed frabbitry closed 4 years ago

frabbitry commented 4 years ago

@biancamaginley @robftg @BMT45 @ebeshero

The guidelines for what should be done with the website for Project Checkpoint 3: Develop a page or pages for the project website, which use

Your file directory for the website on the project repo is there and it looks good. If I could make any recommendations for things to do moving forward, I would suggest that you might want to create separate folders for HTML and CSS (or Javascript, etc., whatever different types of files you end up using). While this might not matter very much for two or three files, the website's capacity to expand and for multiple people to contribute to it will increase if you use a well-thought-out file structure. It takes perhaps two or three minutes to set up at this point in the project; you'll have to add a bit to your file paths in the documents themselves, too. But it makes your files easier to find and store. Check out this source for some good tips on how to set up a good file structure..

I'm a bit confused by the web page itself, because I saw something different on Friday than what's up there now. I think that when I saw it, the index.html that's on the repo was up on the server. THAT index.html includes an SSI and includes a valid filepath in the src attribute of the img tag. However, the one that's up on the server now doesn't use an SSI, and, if you were to put it in oXygen, you'd see that the code doesn't validate because there aren't any filepaths in the src attributes. However, I did see that the SSI menu bar that's in the repo did work when it was up with the index.html file that's also on the repo.

The CSS looks good, and I see that you guys have a good handle on how to use div elements with CSS classes and IDs.

I already expect, just from glancing over the CSS, that the website will show more than it does now (or at least a dropdown menu). Right now, there's a web page up there but it doesn't do much to tell viewers about what the project is about or for. I'm sure that that'll develop later, though. I know that you guys were working a lot with markup so far.

I'm going to point you guys toward W3Schools as a resource, just because it's useful. When you guys start doing more specific things with the website, I'll try to point you towards some more relevant resources, but maybe just look around for some ideas on what you could implement. Maybe you'll end up going with a NASA-style theme. Or maybe you'll go for something more like the visual journeys that are Feed Music and Crypton. I don't know, but I'm looking forward to seeing what you guys come up with.