search

robhagemans / pcbasic

PC-BASIC - A free, cross-platform emulator for the GW-BASIC family of interpreters
http://www.pc-basic.org
Other
396 stars 48 forks source link

pcbasic breaks neovim layout and colors on MacOS Mojave #129

Closed niloct closed 2 years ago

niloct commented 3 years ago

Bug report

pcbasic breaks neovim layout and colors on MacOS Mojave

Problem There are two issues I've identified (both are screencasted, see the attachment gif):

  1. When you execute pc-basic, exits and open neovim, status bar color is changed.
  2. When you execute pc-basic, hits enter till you have to redraw the screen (i.e. the cursor goes below viewport), it totally breaks status bar position (it's "vertically centered" then...)

Steps See attaching gif.

Program No need to code anything.

Notes

PC-BASIC version: 2.0.3
Operating system version: MacOs Mojave Neovim version: v0.4.3 bug_neovim_pcbasic

Thanks for your attention.

niloct commented 3 years ago

Hello anyone ?

niloct commented 3 years ago

For issue 1., the culprit is this line:

https://github.com/robhagemans/pcbasic/blob/6807f35bb5f72ddf993fb11ed9c9336f37dcf612/pcbasic/compat/posix_console.py#L414

If you comment it then the color is not changed when running nvim after closing pc-basic.

robhagemans commented 3 years ago

Hi thanks, what terminal emulator are you using to run bash in?

niloct commented 3 years ago

Hello!

I'm using iterm2.

Em dom, 29 de nov de 2020 06:41, Rob Hagemans notifications@github.com escreveu:

Hi thanks, what terminal emulator are you using to run bash in?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/robhagemans/pcbasic/issues/129#issuecomment-735367443, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALVMJ4FORPLQWCY7X2MFHLSSIJOFANCNFSM4T6OZ2EA .

robhagemans commented 3 years ago

OK, that explains - in Terminal.app I couldn't reproduce the issue. I'll try it out with iTerm2 at some point, though I won't be able to support/test every single terminal emulator.

How have you installed PC-BASIC by the way? I note you don't have SDL2 which should be included in the standard installs. Normally if you start ./pc-basic (and SDL2 is available) you should get a separate window which also supports graphics - the terminal interface you're currently getting is just a fallback.

niloct commented 3 years ago

I haven't :)

I've cloned the repo and ran ./pc-basic.

robhagemans commented 2 years ago

At the moment I am unable to release working MacOS packages and this is unlikely to be resolved unless a Mac user with a recent version of the OS steps up as package maintainer, so I'm going to close this issue as I see no path to its resolution.