search

robherring / gbm_gralloc

Android gralloc module using libgbm API from Mesa
20 stars 42 forks source link

gralloc_gbm: Always map the full buffer size #27

Closed aleasto closed 2 years ago

aleasto commented 2 years ago

Fixes: #22

aleasto commented 2 years ago

I could not find a gralloc hal that actually uses the passed-in coordinates (other than for checking whether they are a valid region). Examples: default(ashmem), qcom, google(mali), minigbm

This sounds like a bug in Skia, but let's make it happy.

aleasto commented 2 years ago

@robherring Can you review this patch?

@maurossi you're welcome to test this on your devices, should work!

scutwukai commented 2 years ago

I could not find a gralloc hal that actually uses the passed-in coordinates (other than for checking whether they are a valid region). Examples: default(ashmem), qcom, google(mali), minigbm

This sounds like a bug in Skia, but let's make it happy.

nice work !! praise you

maurossi commented 2 years ago

@maurossi you're welcome to test this on your devices, should work!

I have tested with r600, radeonsi on Android 11 r-x86, issue #22 is fixed on launcher selection ResolverActivity dialogue and error dialogues