Current README is misaligned with latest release... so we never get any results

robhogan / dynamodb-geo.js

A node-friendly typescript port of https://github.com/awslabs/dynamodb-geo

210 stars 97 forks source link

Current README is misaligned with latest release... so we never get any results #34

Closed aterreno closed 5 years ago

aterreno commented 5 years ago

Hi there, first of all thanks for the fantastic library, I spent quite some time trying to figure out why it wasn't working for us. And I think I am now at the bottom. The issue is this one: https://github.com/rh389/dynamodb-geo.js/pull/27/files#diff-7491f60d55137585fa064f1385087c95L91

So of course, in github you always see the latest readme but ... on NPM you get what's released, I think that misalignment POINT vs Point causes us to always return nothing on the queries.

I've tried many other things, including different versions of aws-sdk, debugging the code, but that seems our issue.

Can you by any chance release 4.1 or whatever other version for this so I can proof my code works?

Thanks.

aterreno commented 5 years ago

Apologies, I just pointed local code running the library from master against our production data and I get results, so that detail is irrelevant.

I can't figure out what changed but master (also with my PR (https://github.com/rh389/dynamodb-geo.js/pull/35) updating the code to all latest libraries) makes my server side code, returning results as expected but if I use 0.4 version I get empty result sets.

aterreno commented 5 years ago

Another update on this: I've published this library under my github account, on github npm and I get the same error as running on 0.4 (aka no results). This is really weird, as pointing locally, to the same codebase works. I start to believe there might be something weird going on with the dependencies and how they are packaged.

For reference, my fork is here: https://github.com/aterreno/dynamodb-geo.js?organization=aterreno&organization=aterreno

aterreno commented 5 years ago

Allright this is a bit of a troubleshoot log now :-)

I think I know now where the problem is/was:

you've got a peerDependency on aws-sdk: that seem to overlap with my own aws-sdk depedendency
the mistery of works from local 'import': well that peer dependency wasn't gettting pulled
the mistery of stopping working after a CI deploy: the npm version there must be old, now NPM doesn't pull peer depedencies
the mistery of not working locally while using the npm dependency: I've upgraded npm and it's fine

I think aws-sdk should not be a peer depedency, I saw your comment on that line of code, in aws lambda that library is always on the node path , so you don't need to include it. We include it to be sure of what version we are running, but that's not strictly necessary.

aterreno commented 5 years ago

Closing this issue, I think the problem has been fixed by my colleague here:

https://github.com/rh389/dynamodb-geo.js/pull/36