Improve filtering ui - Githubissues

robinandeer / puzzle

Variant caller GUI + genetic disease analysis

https://robinandeer.gitbooks.io/puzzle/content/

MIT License

22 stars 7 forks source link

Improve filtering ui #137

Open vasiliosz opened 8 years ago

vasiliosz commented 8 years ago

Here are some suggestions for improving the filtering ui:

[ ] Sliders as input for numeric inputs: frequency filtering, CADD scores and (not implemented) SV size for example
[ ] Reduce size of Gene box
[ ] Drop consequences / impact severity filters from SV mode [EDIT: useful for smaller SVs]
[ ] Change colors of Filter and Reset buttons
[ ] Text and nr indicator of active filter (i.e. 'Filtered, showing 32 of 45000 variants')

guillermo-carrasco commented 8 years ago

Not in the list, but on Friday @robinandeer and me (mainly Robin) implemented the following behaviour:

If there is not filter applied, the Filters dropdown is folded. Otherwise is unfolded.

This way the user quickly knows if a filter is being applied or not.

moonso commented 8 years ago

The filter box open when pushing load more

guillermo-carrasco commented 8 years ago

Hi @vasiliosz ,

Some comments:

I'm not sure sliders are the best choice always in case of numeric input. If the range is too big and/or requires a lot of precision (i.e lots of decimals) can be very uncomfortable to slide a bar. I can see in the frequency filter, for example, that there is 0.0004, this is the kind of precision I'm talking about. What are the possible ranges and precision for the other number input fields?
We talked about indicating something like "Showing X from Y loaded variants", problem is that puzzle doesn't load all variants at once and we may not know how many there are in total. What we could do is load up to a number fixed of variants Z, then show something like "Showing X of Z+ variants, apply another filter to reduce the number of variants"... maybe?

what do you think?

vasiliosz commented 8 years ago

Sounds good @guillermo-carrasco. Agree that sliders may not be practical always, depending on the needed resolution. But it is also not completely intuitive at the moment that you're entering max frequency as fraction.

Does puzzle not count the rows at any point? During load or any other time? If so, I agree with your proposal. The idea is to set some sort of reference for the effect of variant filtration etc

dnil commented 8 years ago

Iff the vcf has been indexed, the number of records would presumably be in the index..

bcftools index -n hapmap_pos.vcf.gz
108

guillermo-carrasco commented 8 years ago

aha! @robinandeer , @moonso does the VCF plugin consider this information?

moonso commented 8 years ago

The problem is to know how many variants that pass a specific filter...