robinandeer / puzzle

Variant caller GUI + genetic disease analysis
https://robinandeer.gitbooks.io/puzzle/content/
MIT License
22 stars 7 forks source link

Show filter results #200

Closed moonso closed 8 years ago

moonso commented 8 years ago
moonso commented 8 years ago

Backend fixed, just need to show result in frontend

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.08%) to 80.935% when pulling 751b1138a1bb93d915c5bc81a98d79ac005db54a on show-filter-results into 001413c80835db5ff8dcaa9d5a4b827e1e47d93f on master.

guillermo-carrasco commented 8 years ago

haha awesome! I was going to ask: where is this shown in the frontend? :-P

The backend looks good to me ^^

moonso commented 8 years ago

Soon @guillermo-carrasco soon

moonso commented 8 years ago

Ok @guillermo-carrasco , @vasiliosz I've added a small message that tells the user how many variants that passed the filter if it is below 1000. Could anyone of you do some data tables magic so that we show 30 variants but keep the rest in memory?

moonso commented 8 years ago

Do you think that 1000 variants is a good number?

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.08%) to 80.935% when pulling b8e6bae4f002f3f0d9bf950df80df407c0fd9093 on show-filter-results into 001413c80835db5ff8dcaa9d5a4b827e1e47d93f on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.04%) to 80.898% when pulling 5384d069c63918d68226fd26870cec912021f0a7 on show-filter-results into 001413c80835db5ff8dcaa9d5a4b827e1e47d93f on master.

vasiliosz commented 8 years ago

Wow you guys are really on fire today. I can check in a week :/ But nr of variants shown is controlled by the js setting, should be easy to find

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.04%) to 80.293% when pulling dcd180d7c0fa4bb84724c234a34b19fa1435c706 on show-filter-results into f04427fc91df2a4966bf74e915b0c5efee87b318 on master.

guillermo-carrasco commented 8 years ago

@moonso done, check out the last commit in this branch :-)

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.04%) to 80.293% when pulling 86c2c6c77cd8d4a1d100d6475b8e509e4e544bb2 on show-filter-results into f04427fc91df2a4966bf74e915b0c5efee87b318 on master.

moonso commented 8 years ago

Fantastic @guillermo-carrasco !!