search

robinandeer / puzzle

Variant caller GUI + genetic disease analysis
https://robinandeer.gitbooks.io/puzzle/content/
MIT License
22 stars 7 forks source link

Frequency filter stopped working? #217

Closed dnil closed 8 years ago

dnil commented 8 years ago

Tested w/ Safari, VEP annotation, vcf-file, init,load&view.

moonso commented 8 years ago

What happens?

dnil commented 8 years ago

Absolutely nothing. Variants are displayed unfiltered.

dnil commented 8 years ago

Where do you set max_freq now? Used to be part of the vcf-adapter variant_extras right?

moonso commented 8 years ago

https://github.com/robinandeer/puzzle/blob/master/puzzle/plugins/vcf/mixins/variant_mixin.py#L316

dnil commented 8 years ago

Thanks; just rediscovered the model part...

dnil commented 8 years ago

Ah, just a missing call to _add_exac...

moonso commented 8 years ago

This was fixed by your PR, right @dnil ?

dnil commented 8 years ago

Right!