robinbowes / flac2mp3

flac2mp3 is a tool to convert audio files from flac to mp3 format including the copying of tags.
GNU General Public License v3.0
142 stars 29 forks source link

Feature request: support symlinks in flacdir #26

Closed davidblewett closed 1 year ago

davidblewett commented 11 years ago

I have a very large music library that won't fit on my portable device. To that end, I created a directory that just holds symlinks to the actual directories I want to transcode. However, when I point flac2mp3.pl at this directory of symlinks it reports that 0 files were found:

pharaon% ls -lah  /home/davidb/music
lrwxr-xr-x   1 davidb  davidb    68B Sep 18 11:41 Harry Connick, Jr. - Chanson du Vieux Carre FLAC@ -> /data/music_archive/Harry Connick, Jr. - Chanson du Vieux Carre FLAC
lrwxr-xr-x   1 davidb  davidb    69B Sep 18 11:41 Harry Connick, Jr. - Every Man Should Know [FLAC]@ -> /data/music_archive/Harry Connick, Jr. - Every Man Should Know [FLAC]
lrwxr-xr-x   1 davidb  davidb    59B Sep 18 11:41 Harry Connick, Jr. - Oh, My Nola [FLAC]@ -> /data/music_archive/Harry Connick, Jr. - Oh, My Nola [FLAC]

Wed Sep 18, 12:18 | /home/davidb/src/flac2mp3
pharaon% ./flac2mp3.pl --tagseparator=";" --processes=2 /home/davidb/music /home/davidb/transcode
Using flac from: /usr/local/bin/flac
Using lame from: /usr/local/bin/lame
Processing directory: /home/davidb/music
Found 0 flac file

Using 2 transcoding processes.

This is on FreeBSD 9.1, using Perl 5.14.

kukolin commented 1 year ago

Same problem here, 10 years later, on Windows:

perl flac2mp3.pl C:\Users\lucas\Downloads\magic C:\Users\lucas\Downloads

Using flac from: C:\Users\lucas\Downloads\flac-1.4.2-win\flac-1.4.2-win\Win64\flac.EXE Using lame from: C:\Users\lucas\Downloads\lame-3.100\lame-3.100\misc\lame.VBS Processing directory: C:\Users\lucas\Downloads\magic Found 0 flac file

Using 1 transcoding processes.

robinbowes commented 1 year ago

As you might have noticed, I haven't touched this code for some time. However, it works for me on MacOS:

$ ls -l symlinks
lrwxr-xr-x@ 1 robin  staff  65 20 Jan 22:53 01 - Daylight Rising.flac -> ../Rips/Steve Tilston/(2021) Such Times/01 - Daylight Rising.flac
lrwxr-xr-x@ 1 robin  staff  67 20 Jan 22:53 02 - Satellites Decree.flac -> ../Rips/Steve Tilston/(2021) Such Times/02 - Satellites Decree.flac
lrwxr-xr-x@ 1 robin  staff  79 20 Jan 22:53 03 - This is Living with the Blues.flac -> ../Rips/Steve Tilston/(2021) Such Times/03 - This is Living with the Blues.flac
lrwxr-xr-x@ 1 robin  staff  69 20 Jan 22:53 04 - It's a Crying Shame.flac -> ../Rips/Steve Tilston/(2021) Such Times/04 - It's a Crying Shame.flac
lrwxr-xr-x@ 1 robin  staff  70 20 Jan 22:53 05 - A Million Miles Away.flac -> ../Rips/Steve Tilston/(2021) Such Times/05 - A Million Miles Away.flac
lrwxr-xr-x@ 1 robin  staff  60 20 Jan 22:53 06 - Such Times.flac -> ../Rips/Steve Tilston/(2021) Such Times/06 - Such Times.flac
lrwxr-xr-x@ 1 robin  staff  65 20 Jan 22:53 07 - 12/8 Pull Off.flac -> ../Rips/Steve Tilston/(2021) Such Times/07 - 12/8 Pull Off.flac
lrwxr-xr-x@ 1 robin  staff  68 20 Jan 22:53 08 - Dust from My Heels.flac -> ../Rips/Steve Tilston/(2021) Such Times/08 - Dust from My Heels.flac
lrwxr-xr-x@ 1 robin  staff  73 20 Jan 22:53 09 - Where Your Mark Remains.flac -> ../Rips/Steve Tilston/(2021) Such Times/09 - Where Your Mark Remains.flac
lrwxr-xr-x@ 1 robin  staff  65 20 Jan 22:53 10 - Waters of March.flac -> ../Rips/Steve Tilston/(2021) Such Times/10 - Waters of March.flac
lrwxr-xr-x@ 1 robin  staff  63 20 Jan 22:53 11 - There's a Man.flac -> ../Rips/Steve Tilston/(2021) Such Times/11 - There's a Man.flac
lrwxr-xr-x@ 1 robin  staff  69 20 Jan 22:53 12 - Nothing to See Here.flac -> ../Rips/Steve Tilston/(2021) Such Times/12 - Nothing to See Here.flac
lrwxr-xr-x@ 1 robin  staff  62 20 Jan 22:53 13 - Four Corners.flac -> ../Rips/Steve Tilston/(2021) Such Times/13 - Four Corners.flac
lrwxr-xr-x@ 1 robin  staff  66 20 Jan 22:53 14 - My Mystery Train.flac -> ../Rips/Steve Tilston/(2021) Such Times/14 - My Mystery Train.flac
lrwxr-xr-x@ 1 robin  staff  62 20 Jan 22:53 15 - Little Flame.flac -> ../Rips/Steve Tilston/(2021) Such Times/15 - Little Flame.flac

$ /flac2mp3.pl symlinks mp3/
Using flac from: /usr/local/bin/flac
Using lame from: /usr/local/bin/lame
Processing directory: /Users/robin/Music/symlinks
Found 15 flac files
Using 1 transcoding processes.

Transcoding    "/Users/robin/Music/symlinks/01 - Daylight Rising.flac"
Writing tags to "/Users/robin/Music/mp3/01 - Daylight Rising.mp3"
...

Can you give me more details of your setup, ie. what OS, perl version, flac2mp3 version, etc?

kukolin commented 1 year ago

Thank you for your response! This is how I setted all up, from scratch: OS: Windows 11 Perl 5.36 Last version as today, downloaded from here flac2mp3 1.0.1 FLAC 1.4.2 last version as today, downloaded from here LAME 3.100 last version as today, downloaded from here Tell me if a specific version is needed

kukolin commented 1 year ago

Ok, I found the problem. I fixed it by unninstalling Perl downloaded from ActiveState and Installing it from strawberryperl.com Now the script worked perfectly. Thank you for the support!