search

robinbowes / flac2mp3

flac2mp3 is a tool to convert audio files from flac to mp3 format including the copying of tags.
GNU General Public License v3.0
143 stars 29 forks source link

Added two improvements: #27

Closed curtisgould closed 10 years ago

curtisgould commented 11 years ago
  1. Added the --preset argument to predefine some of the --lameargs instead of having to retype them every time
  2. Converted all tabs to spaces to match the standards used throughout the rest of the script
anthonyryan1 commented 11 years ago

The flowing additional changes have been made to our fork (https://github.com/whatbox/flac2mp3/pull/1), and in turn added into this pull request:

1) flac2mp3 --help previously returned an error because showhelp() doesn't exist; it will now call showusage() 2) When called without --preset or --lameargs, flac2mp3 would fail to properly read the default presets 3) Parallel::Forkmanager has been renamed to Parallel:ForkManager in order to match the proper casing so that it can be picked up by package managers.

anthonyryan1 commented 10 years ago

@robinbowes would it be easier for you if we split this into a number of small pull requests that are more easily, and independently discussed for merging?

This was originally intended to be a small pull request but the difference has grown due to ongoing maintenance of our fork.

robinbowes commented 10 years ago

Hi,

Yes, lots of small changes is better than one big change.

R.

On 7 January 2014 10:27, Anthony Ryan notifications@github.com wrote:

@robinbowes https://github.com/robinbowes would it be easier for you if we split this into a number of small pull requests that are more easily, and independently discussed for merging?

This was originally intended to be a small pull request but the difference has grown due to ongoing maintenance of our fork.

— Reply to this email directly or view it on GitHubhttps://github.com/robinbowes/flac2mp3/pull/27#issuecomment-31726944 .

anthonyryan1 commented 10 years ago

Pull requests #31 & #32 have been created for review. Issues #33 & #34 have been opened for discussion.

I will be awaiting feedback on issue #32 before submitting the feature that was originally the goal of this pull request, and having it closed later today.