search

robinbowes / flac2mp3

flac2mp3 is a tool to convert audio files from flac to mp3 format including the copying of tags.
GNU General Public License v3.0
142 stars 29 forks source link

Fix mixed tabs and spaces #32

Closed anthonyryan1 closed 10 years ago

anthonyryan1 commented 10 years ago

Until now we have had a haphazard mix of spaces and tabs throughout the code. Since there seemed to be a heavy preference for 4-space indenting rather than tabs. Everything has been converted to spaces. There was no code changed here, only whitespace.

Because this is a whitespace only change, the git diff tool isn't the most helpful way to verify that no code was changed. Here is a side-by-side diff that helps demonstrate that no code was actually changed: http://www.diffchecker.com/3vm3rw2v

robinbowes commented 10 years ago

If we're going to tidy things up, my preference is for 2-space indents.

anthonyryan1 commented 10 years ago

That would be no problem, but it will affect almost every line and your other pull requests and the ability to merge older branches in. Would you like to proceed or leave everything as is? Just let me know which.

anthonyryan1 commented 10 years ago

@robinbowes do you wish to proceed with the tidy-up given the caveat.

anthonyryan1 commented 10 years ago

In the interest of keeping these pull requests moving, I'm going to close this and refrain from other subjective pull requests.

robinbowes commented 9 years ago

It's been a while, but I've run the whole script through perltidy.

Checkout the new v1.0.0 release.