robincornelius / libedssharp

A CanOpen EDS editor and library in C# with CanOpenNode export for Object Dictionary
GNU General Public License v3.0
231 stars 135 forks source link

feature CO_NO_SYNC #200

Open Reissner opened 4 years ago

Reissner commented 4 years ago

Comment of generated CO_OD.h suggests that this depends on entries 0x1005, 0x1006 and 0x1007. The truth is that it is set if 0x1005 is present. But what is missing is to check that if 0x1005 is present, and is so that the node is a sync producer, that then also 0x1006 is present. In contrast, 0x1007 shall be removed from the comment.

Also i can see, that in older versions of CANopenNode, error condition was CO_NO_SYNC != 1 meaning that sync is mandatory. In newer versions it is > 1, the editor cannot produce. There seems to be a mismatch... or maybe a different kind of semantics, but then one has to check whether it is either 0 or 1.