robincornelius / libedssharp

A CanOpen EDS editor and library in C# with CanOpenNode export for Object Dictionary
GNU General Public License v3.0
227 stars 134 forks source link

Adding PDO access permissions #260

Closed StormOli closed 3 years ago

StormOli commented 3 years ago

Closes #259

CANopenNode commented 3 years ago

I made quite a lot of code for the latest versions. But didn't touch tabs: "TX PDO Mapping", "RX PDO Mapping" and "Modules".

"Device Info" and "Object Dictionary" are renewed and additional PDO can be added there. This is more raw approach, but I can currently maintain only that.

As I understand, @robincornelius is quite busy and didn't switch to v4 yet, which introduced quite a lot of changes. And libedssharp is quite extensive.

I can include this PR into CANopenEditor, which is fork of libedssharp and is currently few commits ahead. If there are other fixes to "TX PDO Mapping", "RX PDO Mapping" or else, I would like to include them into CANopenEditor. (#258?) What do you think?

StormOli commented 3 years ago

Hi Janez, I hadn't noticed the new CANopenEditor fork. Seems like a great idea!!! I'll close this pull request and open another there instead