robincornett / genesis-accessible

This plugin fixes some accessibility issues with the Genesis Framework
28 stars 9 forks source link

Move heading for primary menu inside <nav> #1

Closed GaryJones closed 10 years ago

GaryJones commented 10 years ago

<nav> is a sectioning element, so to name it, the heading introduced by Leiden should be inside of it, not before it.

The outline for Leiden home page as it stands:

screenshot 2014-07-26 01 25 12

Having it moved inside the <nav> gives:

screenshot 2014-07-26 01 21 56

Since the primary navigation already has a role attribute, supporting ATs can use this to jump directly to it, or the heading, as before.

rianrietveld commented 10 years ago

Hi Gary,

Looked further into this and came up with the following: Moving the H2 for main/secondary navigation inside the

GaryJones commented 10 years ago

For a good outline the skip-links should also be placed inside the header

+1. I was a little concerned that a h2 Skip Link was getting bumped to the top of the outline, but was going to address that in a new Issue if it hadn't been caught.

rianrietveld commented 10 years ago

Done in develop branche