search

robincornett / genesis-accessible

This plugin fixes some accessibility issues with the Genesis Framework
28 stars 9 forks source link

Archive Headlines #11

Closed robincornett closed 9 years ago

robincornett commented 9 years ago

If a user has the "Use a semantic heading structure" option checked in the plugin's settings, and has a Genesis Headline assigned to the term/CPT (and presumably author, although I have not verified) archive as well, the heading is duplicated (not duplicated, necessarily, if the Genesis headline is set to be something different than the term name or CPT label). The page output looks like this:

image

The Genesis Accessible headline is added below the Genesis Framework headline and description.

My initial thought is that the GA headline function needs to be adjusted: priority needs to be changed so that it would show above the framework block if that exists, and doesn't show if a framework headline is set. This might get a little complicated if there is a framework description but no headline, as the GA headline and framework description both output an archive-description div. I don't have a solution at this point but will look into it.

GaryJones commented 9 years ago

+1. Just been bitten with this myself.

screenshot 2015-01-19 13 43 12

rianrietveld commented 9 years ago

@garyJ and @robincornett: can you please test this again with GA develop, G2.2 with and without Yoast SEO?

rianrietveld commented 9 years ago

In the readme.txt for 2.1 I wrote: = Settings for Genesis version 2.1 =

So you can set the headings via the dashboard, that's why...

I agree this is a rather complex construction and I should have documented that better. Because in Genesis 2.2 this is fixed in core, it's not relevant for G2.2, but I want to leave it as is for GA 1.2. I don't know what I break in sites if I would change this. I will add much ore documentation for this release and add documentation for previous releases too.

@robincornett & @GaryJones: is this ok?

robincornett commented 9 years ago

Isn't it only fixed in 2.2 if genesis_a11y is supported?

Otherwise, if the user has a newer site, and isn't on 2.2, there is still the issue of the GA plugin not outputting a heading at all, if there is no Genesis headline set. (issue #12)