search

robincsamuel / ghost-google-drive

Google drive storage for ghost
MIT License
68 stars 26 forks source link

Some clarifying questions about the codebase #35

Open aknobloch opened 3 years ago

aknobloch commented 3 years ago

Hey folks, currently exploring some different options for moving from a self-hosted server onto a cloud-based one. I came across this storage adapter and it seems like a good way to consolidate some monthly payments, but had a few questions:

  1. Why is the exists() function hardcoded to return true?
  2. The delete() function is marked as Not Implemented. At first I assumed it was just a stale comment, but the comment was checked in commit 333d64dc, which included an implementation? So I'm wondering if there's some part of the delete() function in particular that's not implemented?
  3. It doesn't seem to be much urgency in general, but curious if there are any plans to migrate to Drive API V3?

I'll be happy to follow up on these with PRs addressing (or documenting) the answers. Thanks a ton!

robincsamuel commented 3 years ago

Hey @aknobloch

Thank you so much for taking the time to review and report these issues, and apologies for the delayed response.

The issues you pointed out are basically mistakes.

I focused on getting the basic things to work when I started with this adaptor. The exists() function is more like an unimplemented method but I had to hardcode it to return true for the adaptor to work. I have no clue why delete is marked as Not implemented, I guess I copied the skeleton from somewhere and forgot to remove it.

I wasn't planning any updates, but I'd be happy to keep the adapter up-to-date. I'm not following Ghost these days and would definitely need help from people like you to maintain the project. So, I think, we can fix these issues and probably plan to migrate the Drive APIs.

Thanks again :)