search

robincsamuel / ghost-google-drive

Google drive storage for ghost
MIT License
68 stars 26 forks source link

Use Google Drive API v3 #38

Closed behoyh closed 2 years ago

behoyh commented 2 years ago

This PR adds Google Drive API v3 capabilities to Ghost. There should be no breaking changes, while benefits from the new authenticated quota system and increased ease of use should make this plugin on-par with other Ghost storage plugins in terms of performance and reliability.

robincsamuel commented 2 years ago

Thanks, @behoyh! I'll find some time this week to review and merge this PR.

behoyh commented 2 years ago

Happy to help!

behoyh commented 2 years ago

Nice work, @behoyh

I've commented on a couple of really minor issues, we can merge as soon as you resolve them.

Also, since you almost rewrote the code, I think it's an opportunity to clean up a bit. Like using async/await, const/let instead of var, etc.

Thanks!

Hey @robincsamuel,

For sure. Also I wanted to cut the extraneous exists() call in serve(), it seems like a waste of resources to what just amounts to downloading the image twice. I'll work on the changes and resolve when I do!

behoyh commented 2 years ago

Fixes #26

behoyh commented 2 years ago

Fixes #36

robincsamuel commented 2 years ago

Thanks @behoyh